Use FormatMessage directly for Winsock errors - #9384
Merged
Conversation
8 tasks
nbolton
changed the title
FormatMessage for Winsock errors instead of hard-coding them
nbolton
changed the title
FormatMessage for Winsock errors instead of hard-coding themFormatMessage directly for Winsock errors
sithlord48
approved these changes
Jan 22, 2026
sithlord48
left a comment
sithlord48
left a comment
Member
There was a problem hiding this comment.
Love to see unneeded code go !!!
Member
Author
@sithlord48 ☝️ - Do you agree? |
sithlord48
force-pushed
the
winsock-errors
branch
from
January 22, 2026 13:30
534c768 to
81a320b
Compare
Member
|
No i think this is good since we will now just report the winstock "default" error string not our own like we used to . |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uses
FormatMessagefor Winsock errors instead of hard-coding them.Related Issue
Based on: #9337
May fix: #9067 (but needs testing)
How Has This Been Tested?
Not yet tested, Winsock errors are hard to reproduce.
We should wait until a user confirms that this fixes the issue (I am not in a rush to merge this).
CC @benrg