refactor: WlClipboard, close not kill running copy process on exit - #9380
Merged
Conversation
nbolton
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Call
QProcess::close()instead ofQProcess::kill()on close of WlClipboard objectRelated Issue
No reported issue but sometimes i will stop deskflow (using the button) and then i can't start it again because the port is in use. when calling
netstat -anlp 24800and see the process holding the port was wl-copy . after forcefully killing wl-copy (kill -9 was needed) i was able to start the core again. This is very rare i've seen it twice since our addition of wl-clipboard support. Not sure this will fix it or is related but callingQProcess::closeis a cleaner exit either wayHow Has This Been Tested?
Running locally testing clipboard a bit. to ensure its working.