Skip to content

fix: gui crash on clearsettings in debug mode - #9374

Merged
nbolton merged 1 commit into
masterfrom
fixCrashOnSettingsClear
Jan 22, 2026
Merged

fix: gui crash on clearsettings in debug mode#9374
nbolton merged 1 commit into
masterfrom
fixCrashOnSettingsClear

Conversation

@sithlord48

@sithlord48 sithlord48 commented Jan 20, 2026

Copy link
Copy Markdown
Member

Description

disconnect items when clearing the settings to avoid crash when sending queued events.

Related Issue

fixes: #9369
replaces: #9373

How Has This Been Tested?

Run in debug cleared settings

@sithlord48
sithlord48 requested a review from a team January 20, 2026 12:27
@sithlord48
sithlord48 requested a review from nbolton as a code owner January 20, 2026 12:27
@sithlord48 sithlord48 added the 🩹 fix This PR fixes a reported bug label Jan 20, 2026
@sithlord48
sithlord48 force-pushed the fixCrashOnSettingsClear branch from 3bbe87f to ddb1377 Compare January 20, 2026 12:44
@nbolton
nbolton force-pushed the fixCrashOnSettingsClear branch from ddb1377 to afba85c Compare January 22, 2026 12:36

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely with debug build, thanks for fixing bugs in debug builds ❤️

@nbolton
nbolton enabled auto-merge (rebase) January 22, 2026 12:45
@nbolton
nbolton merged commit c7a427a into master Jan 22, 2026
34 checks passed
@nbolton
nbolton deleted the fixCrashOnSettingsClear branch January 22, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🩹 fix This PR fixes a reported bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All hell breaks loose when clearing settings with debug build

2 participants