Clear invalid settings - #9359
Merged
Merged
Conversation
8 tasks
sithlord48
force-pushed
the
clearInvalidSettings
branch
from
January 18, 2026 16:00
34e5ec3 to
f701305
Compare
This was referenced Jan 18, 2026
sithlord48
force-pushed
the
clearInvalidSettings
branch
from
January 19, 2026 03:40
f701305 to
9436357
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
nbolton
approved these changes
Jan 19, 2026
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
Works fine with release build...
…ty setting values. This is because QVariant::isNull() no longer returns the internal types isNull() method. As a results "" is a non Null QVariant
…fault windowgeometry as it will be cast to QVariant automaticly on return
…emove keys as long as they are empty
Settings will call cleanSettigs and cleanStateSettings on start up to remove any invalid or empty values in our config fixes: #9333
nbolton
force-pushed
the
clearInvalidSettings
branch
from
January 19, 2026 22:40
9436357 to
e0d07bf
Compare
nbolton
enabled auto-merge (rebase)
January 19, 2026 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #9333
Settings::value().isNull()=>Settings::value().toString().isEmpty()QVariant()forSettings::setValue()calls that are removing value as QVariant() is the default value forSettings::setValueSettings::cleanSettings()