Feat: Support multiple server IP addresses (#3665) - #9355
Merged
sithlord48 merged 1 commit intoJan 17, 2026
Conversation
sithlord48
requested changes
Jan 17, 2026
sithlord48
marked this pull request as draft
January 17, 2026 12:30
Member
|
@Ashutosh0x please rebase this upon current master and fix the one commit issue and lint this seams ok otherwise. |
Contributor
Author
|
@sithlord48 Feedback addressed:
|
sithlord48
marked this pull request as ready for review
January 17, 2026 15:30
sithlord48
requested changes
Jan 17, 2026
Member
There was a problem hiding this comment.
I added two IPs 192.168.0.100, 192.168.0.101 for the client to connect. The first Ip does not have deskflow running and i expect it to connect to the second ip as that is a running server
However this does not happen it just tries the first ip over and over.
initial settings file: /Users/chris/Library/Deskflow/Deskflow.conf
[2026-01-17T10:39:34.480] NOTE: configured 2 server address(es)
[2026-01-17T10:39:34.496] NOTE: started client
[2026-01-17T10:39:34.496] IPC: connecting to '192.168.0.100': 192.168.0.100:24800
2026-01-17 10:39:34.532 deskflow-core[34553:1238247] starting cocoa loop
[2026-01-17T10:39:35.635] WARNING: failed to connect to server=Connection refused, trying next server in list
[2026-01-17T10:39:36.640] IPC: connecting to '192.168.0.100': 192.168.0.100:24800
[2026-01-17T10:39:37.666] WARNING: failed to connect to server: Connection refused
[2026-01-17T10:39:38.671] IPC: connecting to '192.168.0.100': 192.168.0.100:24800
[2026-01-17T10:39:39.677] WARNING: failed to connect to server=Connection refused, trying next server in list
[2026-01-17T10:39:40.680] IPC: connecting to '192.168.0.100': 192.168.0.100:24800
[2026-01-17T10:39:41.691] WARNING: failed to connect to server: Connection refused
[2026-01-17T10:39:42.696] IPC: connecting to '192.168.0.100': 192.168.0.100:24800
[2026-01-17T10:39:43.707] WARNING: failed to connect to server=Connection refused, trying next server in list
[2026-01-17T10:39:44.713] IPC: connecting to '192.168.0.100': 192.168.0.100:24800
[2026-01-17T10:39:45.724] WARNING: failed to connect to server: Connection refused
[2026-01-17T10:39:46.726] IPC: connecting to '192.168.0.100': 192.168.0.100:24800
[2026-01-17T10:39:47.737] WARNING: failed to connect to server=Connection refused, trying next server in list
[2026-01-17T10:39:48.743] IPC: connecting to '192.168.0.100': 192.168.0.100:24800
[2026-01-17T10:39:49.753] WARNING: failed to connect to server: Connection refused
[2026-01-17T10:39:50.759] IPC: connecting to '192.168.0.100': 192.168.0.100:24800
[2026-01-17T10:39:51.769] WARNING: failed to connect to server=Connection refused, trying next server in list
Setting to draft, once you have this working mark it ready for review and ill test again
sithlord48
marked this pull request as draft
January 17, 2026 15:44
Member
|
your local copies base is old ill update the pr but if you need to update it again remember to rebase locally first |
sithlord48
marked this pull request as ready for review
January 17, 2026 16:15
sithlord48
approved these changes
Jan 17, 2026
sithlord48
left a comment
sithlord48
left a comment
Member
There was a problem hiding this comment.
Looks good did a local test and it was able to connect to the second item on the list without issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3665. Adds support for specifying multiple server IP addresses as a comma-separated list. The client will try each address in sequence when connecting.
Features:
Example: Set RemoteHost to '192.168.1.100, 10.0.0.50, server.local' to try multiple servers.