Feat: Add Ctrl+F search for log section (#8332) - #9354
Conversation
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
Does not build.
Do not submit code you have not locally build and tested.
|
@sithlord48 Added missing includes (QIcon, QFontDatabase) to LogWidget.cpp and cleaned up LogWidget.h. Should build now. |
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
the problem was not your missing includes its you using slots instead of Q_SLOTS . Are you even building these changes before you submit
|
you have not fixed the build issues. |
|
@sithlord48 Fixed the style issue by replacing slots with Q_SLOTS in LogWidget.h. I apologize for the oversight; I am focusing on ensuring compatibility with the project's coding standards. |
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
Please fix the lint issues.
Remove any unneeded includes
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
Do not fix proposed commits with new commits.
append commits 2 and 3 to commit 1
|
@sithlord48 I've updated the log search icons to use |
|
@sithlord48 I've updated the log search icons to use |
There was a problem hiding this comment.
It works (had to rebased again, your local base it not upto date
I really don't like the UX around this..ill likey redo it all.
Idk that we should use keyboard shortcut for this but instead a button.. If you dont mind i might take this over for the UX parts.
id perfer a search button that when depressed expands to show the search controls
|
@sithlord48 No problem at all! I'm glad the functional part works. I definitely don't mind you taking over the UX parts your better understanding of the project's design language will ensure a much better result. Thank you for the guidance and for taking the time to refine this! |
|
Btw we have a matrix channel if you plan to contribute alot might be a good idea to join it |
|
@sithlord48 Thanks for the invite! I'd love to join the Matrix channel — where can I find the link or address? I'm definitely interested in contributing more to the project. |
its in the main readme |
i have joined the discussion |
|
Replaced by #9356. |
2 participants
Fixes #8332. Adds Ctrl+F keyboard shortcut to search the log section in the main window.
Features: