refactor: update icon creation and url handling - #9343
Merged
Conversation
Member
|
Ill add to this the removal of the other too QIcons casts here as well. |
sithlord48
approved these changes
Jan 16, 2026
sithlord48
left a comment
sithlord48
left a comment
Member
There was a problem hiding this comment.
@nbolton Ill let you land after you review.
sithlord48
force-pushed
the
bugfix
branch
2 times, most recently
from
January 17, 2026 16:34
6bac89c to
7512ef0
Compare
sithlord48
force-pushed
the
bugfix
branch
2 times, most recently
from
January 19, 2026 03:41
ec673af to
1845812
Compare
explict cast when setting update url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update icon creation and url handling in order to keep same code style.
Log: update icon creation and url handling.