Skip to content

fix: OSXScreenSaver, do not call CFRelease for empty processes - #9327

Merged
sithlord48 merged 1 commit into
masterfrom
fix_9326
Jan 13, 2026
Merged

fix: OSXScreenSaver, do not call CFRelease for empty processes#9327
sithlord48 merged 1 commit into
masterfrom
fix_9326

Conversation

@sithlord48

@sithlord48 sithlord48 commented Jan 8, 2026

Copy link
Copy Markdown
Member

fixes: #9326
as suggested do not release if we have nullptr.

@sithlord48
sithlord48 requested a review from a team January 8, 2026 21:06
@sithlord48
sithlord48 requested a review from nbolton as a code owner January 8, 2026 21:06
@sithlord48 sithlord48 added 🍎 mac This issue affects macOS 🩹 fix This PR fixes a reported bug labels Jan 8, 2026
@sithlord48
sithlord48 force-pushed the fix_9326 branch 3 times, most recently from c71c6f0 to 5219540 Compare January 10, 2026 16:56

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing now. Thank you
#9326 (comment)

We should wait until we hear back from @Rendann before landing.

@Rendann

Rendann commented Jan 12, 2026

Copy link
Copy Markdown

Seems to be fixed on my end. Thanks for the ping, and for taking care of things so quickly.

(for reference, I've been testing this version: #9326 (comment))

@sithlord48
sithlord48 merged commit d8dfba6 into master Jan 13, 2026
34 checks passed
@sithlord48
sithlord48 deleted the fix_9326 branch January 13, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍎 mac This issue affects macOS 🩹 fix This PR fixes a reported bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS: Crash in OSXScreenSaver::processLaunched when CopyProcessName fails (SIGBUS exit code 10)

3 participants