Use arch daemon windows directly - #9316
Merged
Merged
Conversation
sithlord48
force-pushed
the
useArchDaemonWindowsMore
branch
from
January 3, 2026 14:59
58c177d to
fff92d3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
removes: unused DAEMON_RUNNING define in App.h unused ArchMiscWindows::daemonRunning update copyright years
remove now unused ArchMiscWindows::getDaemonQuitMessage
remove now unused ArchMiscWindows::daemonFailed update copyright year
remove now unused ArchMiscWindows::runDaemon
sithlord48
force-pushed
the
useArchDaemonWindowsMore
branch
from
January 5, 2026 12:07
fff92d3 to
aff0c69
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
I believe we only need to worry about what |
Member
Author
|
This is ready anything extra we should do after this. |
nbolton
reviewed
Jan 6, 2026
Member
Author
|
daemonRunning is used on windows when in "service" mode. Edit: your right this is no longer needed in client/server only the deamon (good catch :D) |
sithlord48
enabled auto-merge (rebase)
January 6, 2026 11:48
nbolton
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed we have this abstraction around the ArchDaemonWindows calls. All the items can just include ArchDaemonWindows.
ArchDaemonWindowscalls and use them directlydaemonRunningDAEMON_RUNNINGin App.hServerApp::daemonMainLoopStaticandClientApp::daemonMainLoopStaticApp::daemonMainLoopApp::daemonInfo,ServerApp::daemonInfoandClientApp::daemonInfo