Skip to content

Give our loose headers proper library homes - #9309

Merged
nbolton merged 2 commits into
masterfrom
moveLooseHeaders
Dec 30, 2025
Merged

Give our loose headers proper library homes#9309
nbolton merged 2 commits into
masterfrom
moveLooseHeaders

Conversation

@sithlord48

@sithlord48 sithlord48 commented Dec 30, 2025

Copy link
Copy Markdown
Member

The loose headers now have more distinct uses and with that its more sane to move them where they fit. Config.h is now only used for XWindows parts of the platform lib. VersionInfo would now make more sense as part of common lib.

  • Use a list of dirs when calling include_directories in src/CMakeLists.txt
  • Mv src/lib/VersionInfo.h.in -> src/lib/common/VersionInfo.h.in
    • Adjust VersionInfo.h.in to respect the clang format rules.
  • Mv src/lib/Config.h.in -> src/lib/platform/XWindowsConfig.h.in
    • Use #define to create the defines
    • Add #pragma once
    • Included only with X11_Platform support
    • Remove its unneeded inclusion in gui/MainWindow.cpp
    • Remove unused define HAVE_CONFIG_H

@sithlord48
sithlord48 requested a review from a team December 30, 2025 16:37
@sithlord48 sithlord48 added the 🚧 build Build related change label Dec 30, 2025
@sithlord48
sithlord48 requested a review from nbolton as a code owner December 30, 2025 16:37
@sithlord48 sithlord48 changed the title Move loose headers Give our loose headers proper library homes Dec 30, 2025
@nbolton
nbolton enabled auto-merge (rebase) December 30, 2025 16:53
@nbolton
nbolton merged commit 7682e17 into master Dec 30, 2025
33 of 34 checks passed
@nbolton
nbolton deleted the moveLooseHeaders branch December 30, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚧 build Build related change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants