fix: Restore clipboard sharing after 53441821e - #9307
Merged
Conversation
sithlord48
approved these changes
Dec 29, 2025
8 tasks
We wanted the value contained in the string as size_t, not the size (length) of the string. size_t is (normally) an alias for unsigned long, so toUlong() should do the trick.
nbolton
approved these changes
Dec 30, 2025
nbolton
enabled auto-merge (rebase)
December 30, 2025 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wanted the value contained in the string as size_t, not the size (length) of the string. size_t is (normally) an alias for unsigned long, so toUlong() should do the trick.
This broke at least with X11 <-> X11, where it caused messages like
[2025-12-29T20:15:28.221] ERROR: corrupted clipboard data, expected size=3 actual size=378
[2025-12-29T20:15:28.221] ERROR: corrupted clipboard data, expected size=2 actual size=52
Edit:
fixes: #9279