Skip to content

Screen dialog cleanup - #9304

Merged
nbolton merged 11 commits into
masterfrom
screenDialogCleanup
Dec 30, 2025
Merged

Screen dialog cleanup#9304
nbolton merged 11 commits into
masterfrom
screenDialogCleanup

Conversation

@sithlord48

@sithlord48 sithlord48 commented Dec 24, 2025

Copy link
Copy Markdown
Member

Cleanup style related items.

  • Setting the style sheet is expensive so lets do it only when necessary.
  • Adjust how the LineEditValidator styles lines with invalid input
    • Make it look more native based on the Qt Style in use, The style changing (not just the border) is visual noise.
      • fusion , Default used on windows / and non KDE XDG desktops
      • breeze , KDE's default style
      • macos , Used on mac os
      • windows not used by default but a stock style for Qt. Win98 like
  • Remove gui/styles
  • Use the Palette to color error related items when possible
Style Before After
Fusion old-fusionNormal
old-fusionError
new-fusionNormal
new-fusionError
Breeze old-breezeNormal
old-breezeError
new-breezeNormal
new-breezeError
macos old-macosNormal
old-macosError
Screenshot 2025-12-27 at 10 54 06 AM
Screenshot 2025-12-27 at 10 54 31 AM
win98 old-win98Normal
old-win98Error
new-win98Normal
new-win98Error

@sithlord48
sithlord48 requested a review from a team December 24, 2025 16:31
@sithlord48
sithlord48 requested a review from nbolton as a code owner December 24, 2025 16:31
@nbolton
nbolton merged commit 9976caa into master Dec 30, 2025
34 checks passed
@nbolton
nbolton deleted the screenDialogCleanup branch December 30, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants