build (win32): exclude any icu*.dll from the windows packages - #9278
Merged
Conversation
8 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sithlord48
added
🪟 windows
This comment was marked as outdated.
This comment was marked as outdated.
sithlord48
force-pushed
the
includeICU
branch
from
December 15, 2025 16:27
c049547 to
034a8df
Compare
sithlord48
changed the title
Member
Author
|
I've fixed this to not include the any icu related dlls. This makes it so we are always using the system provided ones. |
sithlord48
enabled auto-merge (rebase)
December 15, 2025 16:44
Member
|
Sounds like a better idea, I'll give this a try on W10 and W11 VMs. |
nbolton
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that our windows deployments do not include any
icu.dllfiles.I have tested on: