Skip to content

feat(network): add network monitoring with IP selection - #9270

Merged
nbolton merged 2 commits into
deskflow:masterfrom
re2zero:feat
Dec 30, 2025
Merged

feat(network): add network monitoring with IP selection#9270
nbolton merged 2 commits into
deskflow:masterfrom
re2zero:feat

Conversation

@re2zero

@re2zero re2zero commented Dec 10, 2025 •
edited by sithlord48
Loading

Copy link
Copy Markdown
Contributor

Fixes: #9093

  • Implement NetworkMonitor class to track network configuration changes
  • Populate the setting's network selector to allow users to pick an interface
  • Monitor network interfaces and emit signals for IP address changes
  • Prioritize 192.168.x.x addresses as suggested IP selections

Log: add network monitoring with IP selection.

EDIT: *updated by sithlord48

  • Update label in with new IP's if the server is not running
  • Update if the ips you can use if running , but do not add new ones (as they will not be valid)
  • Adjust settings gui to have IP selection on left and port on right of network section
Screenshot_20251230_090740

@re2zero
re2zero requested a review from a team December 10, 2025 06:18
@re2zero

This comment was marked as outdated.

Sign in to view
@nbolton

This comment was marked as outdated.

Sign in to view
sithlord48

This comment was marked as outdated.

Sign in to view

@sithlord48 sithlord48 added the ✨ enhancement A suggested change to improve functionality label Dec 10, 2025
sithlord48
sithlord48 reviewed Dec 10, 2025
View reviewed changes
Comment thread src/lib/gui/core/network/NetworkMonitor.h Outdated
sithlord48
sithlord48 reviewed Dec 10, 2025
View reviewed changes
Comment thread src/lib/gui/core/network/NetworkMonitor.h Outdated
sithlord48
sithlord48 reviewed Dec 10, 2025
View reviewed changes
Comment thread src/lib/gui/core/network/NetworkMonitor.h Outdated
sithlord48
sithlord48 reviewed Dec 10, 2025
View reviewed changes
Comment thread src/lib/gui/core/network/NetworkMonitor.cpp Outdated
sithlord48
sithlord48 reviewed Dec 10, 2025
View reviewed changes
Comment thread src/lib/gui/core/network/NetworkMonitor.cpp Outdated
sithlord48
sithlord48 reviewed Dec 10, 2025
View reviewed changes
Comment thread src/lib/gui/core/network/NetworkMonitor.cpp Outdated
sithlord48
sithlord48 reviewed Dec 10, 2025
View reviewed changes
Comment thread src/lib/gui/core/network/NetworkMonitor.cpp Outdated
sithlord48
sithlord48 reviewed Dec 10, 2025
View reviewed changes
Comment thread src/lib/gui/core/network/NetworkMonitor.h Outdated
@sithlord48

This comment was marked as outdated.

Sign in to view
sithlord48

This comment was marked as outdated.

Sign in to view

sithlord48
sithlord48 reviewed Dec 11, 2025
View reviewed changes
Comment thread src/lib/gui/core/network/NetworkMonitor.h Outdated
@sithlord48

This comment was marked as outdated.

Sign in to view
sithlord48
sithlord48 reviewed Dec 11, 2025
View reviewed changes
Comment thread src/lib/gui/MainWindow.cpp Outdated
@re2zero

This comment was marked as outdated.

Sign in to view
sithlord48

This comment was marked as outdated.

Sign in to view

@re2zero
re2zero force-pushed the feat branch 3 times, most recently from 3364045 to da012c7 Compare December 12, 2025 03:37
sithlord48

This comment was marked as outdated.

Sign in to view

@sithlord48
sithlord48 self-requested a review December 12, 2025 13:17
sithlord48

This comment was marked as outdated.

Sign in to view

@sithlord48
sithlord48 marked this pull request as ready for review December 19, 2025 18:44
sithlord48
sithlord48 previously approved these changes Dec 19, 2025
View reviewed changes

@sithlord48 sithlord48 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready now!

@sithlord48
sithlord48 force-pushed the feat branch 2 times, most recently from 65782b8 to cbec324 Compare December 22, 2025 18:22
sithlord48
sithlord48 previously approved these changes Dec 22, 2025
View reviewed changes
nbolton
nbolton requested changes Dec 23, 2025
View reviewed changes

@nbolton nbolton left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: I noticed that the suggest IP doesn't show on first load, only when you toggle to client and back to server.

Comment thread src/lib/gui/MainWindow.cpp Outdated
@sithlord48

sithlord48 commented Dec 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Bug: I noticed that the suggest IP doesn't show on first load, only when you toggle to client and back to server.

I am starting in server mode and I see it right away. Are you starting in server mode?

Edit: When its started in server but not running yet.. I can see this , (and fixed)

sithlord48
sithlord48 previously approved these changes Dec 23, 2025
View reviewed changes

@sithlord48 sithlord48 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nbolton
nbolton reviewed Dec 24, 2025
View reviewed changes
Comment thread src/lib/gui/dialogs/SettingsDialog.ui Outdated
@sithlord48
sithlord48 requested a review from nbolton December 24, 2025 13:11
@re2zero @sithlord48
feat: add network monitoring and IP address management
cf2b380 
- introduce NetworkMonitor class to track network addresses change
- replace QLineEdit with QComboBox for interface selection in settings
- implement automatic IP detection and suggestion logic
- add signal-slot connections for real-time network updates

Log: add network monitoring and IP address management.
@nbolton
nbolton enabled auto-merge (rebase) December 30, 2025 17:02
sithlord48
sithlord48 approved these changes Dec 30, 2025
View reviewed changes

@sithlord48 sithlord48 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "Automatic"

@nbolton
nbolton merged commit d27fd22 into deskflow:master Dec 30, 2025
32 checks passed
@re2zero
re2zero deleted the feat branch December 31, 2025 00:46
@sithlord48 sithlord48 mentioned this pull request Dec 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes
@sithlord48 sithlord48 sithlord48 approved these changes

Assignees

No one assigned

Labels

✨ enhancement A suggested change to improve functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Ip on Mainwindow when it changes

3 participants

@re2zero @nbolton @sithlord48