Skip to content

I18N use short (ISO639) names to save and load - #9258

Merged
sithlord48 merged 1 commit into
masterfrom
i18nSaveShort639Name
Dec 4, 2025
Merged

I18N use short (ISO639) names to save and load #9258
sithlord48 merged 1 commit into
masterfrom
i18nSaveShort639Name

Conversation

@sithlord48

Copy link
Copy Markdown
Member

Update I18N to use short names to load and save the language. Provide methods for settings to get the native string and convert between them .

Our documentation says we do this already .

Settings will save the language in the settings file as en not English , ja not 日本語 and so on ..

@sithlord48
sithlord48 requested a review from a team December 3, 2025 22:05
@sithlord48
sithlord48 requested a review from nbolton as a code owner December 3, 2025 22:05
@sithlord48 sithlord48 changed the title refactor: I18N use short (ISO639) names to save and load I18N use short (ISO639) names to save and load Dec 3, 2025
@sithlord48
sithlord48 force-pushed the i18nSaveShort639Name branch from 96a621a to 4cf9fdb Compare December 3, 2025 22:06
@nbolton

nbolton commented Dec 4, 2025

Copy link
Copy Markdown
Member

I'm seeing:

/home/nick/Projects/deskflow/src/lib/common/I18N.h:37: warning: argument 'lang' of command @param is not found in the argument list of I18N::toNativeName(QString shortName)
/home/nick/Projects/deskflow/src/lib/common/I18N.h:37: warning: The following parameter of I18N::toNativeName(QString shortName) is not documented:
  parameter 'shortName'

Comment thread src/lib/common/I18N.h Outdated
…trings, the documentation says we use these already
@sithlord48
sithlord48 force-pushed the i18nSaveShort639Name branch from 4cf9fdb to 649c905 Compare December 4, 2025 11:50
@sithlord48
sithlord48 requested a review from nbolton December 4, 2025 11:50
@sithlord48
sithlord48 merged commit b151666 into master Dec 4, 2025
34 checks passed
@sithlord48
sithlord48 deleted the i18nSaveShort639Name branch December 4, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants