Remove deskflow::filesystem::path - #9243
Merged
Merged
Conversation
sithlord48
force-pushed
the
rmBasePath
branch
from
December 2, 2025 03:36
1e2e4e6 to
c58c494
Compare
…reSocket::loadCertificate(const QString &)
nbolton
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use QStrings to replace the need for
deskflow::filesystem::pathThis ranges second commit changes
base/Pathto use the same method we will use later inServerApp::loadConfig. This can be used to verify the method is working as ServerApp currently lacks tests.App::loadConfig(const std::string &)=>App::loadConfig(const QString &)SecureUtils::loadCertificates(const std::string &)=>SecureUtils::loadCertificate(const QString &)SecureUtils::SecureConnectionfor name verification (sonar failed the build without it)SecureSocket::doWriteShould do some quick testing on windows to verify (i did a quick smoke test in the windows vm)
Tested on