Restore the gui starting the core based on it state at exit - #9238
Merged
Conversation
sithlord48
added
🩹 fix
nbolton
previously approved these changes
Dec 1, 2025
Member
|
Approved, but added some minor grammer nits if you want to fix. |
…essage popup on initial connection a to client / server
…should start the core when starting up removes Settings::Core::StartedBefore
sithlord48
force-pushed
the
fixNoRunOnStart
branch
from
December 1, 2025 13:40
cd52da1 to
b0759bc
Compare
sithlord48
enabled auto-merge (rebase)
December 1, 2025 13:40
nbolton
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
Settings::Core::StartedBeforespiting it into 3 settings. This settings was doing to much and as a result we broke the ability to start desktop gui w/o the core running if it had been started beforeSettings::Gui::ShownFirstConnectedMessagecontrols if we have shown the message when deskflow has connected for the first timeSettings::Gui::ShownFirstServerStartMessagecontrols if we have shown the message for the first time you start deskflow in server modeSettings::Gui::AutoStartCoreControls if the GUI should start the core when starting up. This is controlled by the state of the core when the gui exits.