Skip to content

Fix: Gui resizes with client errors - #9236

Merged
sithlord48 merged 2 commits into
masterfrom
handleDialogSkipinGui
Dec 1, 2025
Merged

Fix: Gui resizes with client errors#9236
sithlord48 merged 2 commits into
masterfrom
handleDialogSkipinGui

Conversation

@sithlord48

@sithlord48 sithlord48 commented Nov 30, 2025

Copy link
Copy Markdown
Member
  • MainWindow::showAndActivate only call restoreWindow if the window was hidden (fixes: Gui could resize on client errors #9237)
  • Make sure that MainWindow is the object that checks if it should call create a message based on the user preference (not Message)

@sithlord48
sithlord48 requested a review from a team November 30, 2025 16:30
@sithlord48
sithlord48 requested a review from nbolton as a code owner November 30, 2025 16:30
@sithlord48
sithlord48 marked this pull request as draft November 30, 2025 16:36
@sithlord48
sithlord48 marked this pull request as ready for review November 30, 2025 16:42
@sithlord48 sithlord48 linked an issue Nov 30, 2025 that may be closed by this pull request
@sithlord48 sithlord48 changed the title refactor: handle error suppression in gui not message stack Fix: Gui resizes with client errors Nov 30, 2025
@sithlord48
sithlord48 force-pushed the handleDialogSkipinGui branch from 8695a0b to 0c84d8e Compare December 1, 2025 13:22
@sithlord48
sithlord48 enabled auto-merge (rebase) December 1, 2025 13:27
@sithlord48
sithlord48 merged commit 13219ca into master Dec 1, 2025
33 of 34 checks passed
@sithlord48
sithlord48 deleted the handleDialogSkipinGui branch December 1, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gui could resize on client errors

2 participants