fix: Mac os Preferences missing when translated - #9231
Merged
Conversation
sithlord48
changed the title
sithlord48
force-pushed
the
fixMacHelpMenu
branch
from
November 29, 2025 15:27
c859501 to
0b4f12b
Compare
Contributor
|
I cannot build a macOS binary right now, so I'll check when the continuous build is available. |
Member
Author
|
You can always try the action results https://github.com/deskflow/deskflow/actions/runs/19785789972 |
Contributor
|
I'm on my Intel iMac at home, and the application in the macos-x64 artifact refused to run, saying "Deskflow.app is damaged and can't be opened." |
Member
Author
|
You need to run xattr -c on the app before you can run it ,, thanks apple.. the homebrew package does this in a post flight step |
Contributor
|
I can now access Preference. Thank you very much. |
nbolton
approved these changes
Nov 30, 2025
fixes: #9226 In the MainWindow give all menu items a role to prevent mac os from misplacing them due to their label when translated
sithlord48
force-pushed
the
fixMacHelpMenu
branch
from
November 30, 2025 14:57
0b4f12b to
416a081
Compare
sithlord48
enabled auto-merge (rebase)
November 30, 2025 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #9226
In the MainWindow give all menu items a role to prevent mac os from misplacing them due to their label when translated
@ykasap can you check this out should be good now it fixed it for me