Skip to content

Server Connection use signals for new client dialog - #9230

Merged
sithlord48 merged 3 commits into
masterfrom
scSignals
Nov 30, 2025
Merged

Server Connection use signals for new client dialog#9230
sithlord48 merged 3 commits into
masterfrom
scSignals

Conversation

@sithlord48

@sithlord48 sithlord48 commented Nov 28, 2025

Copy link
Copy Markdown
Member
  • Server conneciton use signals / slots to request a newclient join
  • Qt Tests for ServerConnection
  • Fixed a unreported bug where ignored clients (without peerauth) will continue to ask to be added.

@sithlord48
sithlord48 requested a review from a team November 28, 2025 22:14
@sithlord48
sithlord48 requested a review from nbolton as a code owner November 28, 2025 22:14
@sithlord48 sithlord48 added the ✨ enhancement A suggested change to improve functionality label Nov 28, 2025
@deskflow deskflow deleted a comment from github-actions Bot Nov 28, 2025
@sithlord48
sithlord48 marked this pull request as draft November 28, 2025 22:33
@sithlord48 sithlord48 added this to the 1.26.0 milestone Nov 28, 2025
@sithlord48
sithlord48 force-pushed the scSignals branch 2 times, most recently from fde4ff2 to eaae6bb Compare November 30, 2025 04:12
@nbolton

nbolton commented Nov 30, 2025

Copy link
Copy Markdown
Member

Undraft After #9229

Ah, conflicts

@sithlord48
sithlord48 marked this pull request as ready for review November 30, 2025 14:14

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, same as other one, only had time for smoke test.

@sithlord48
sithlord48 enabled auto-merge (rebase) November 30, 2025 14:26
@sithlord48
sithlord48 merged commit c1b5e12 into master Nov 30, 2025
34 checks passed
@sithlord48
sithlord48 deleted the scSignals branch November 30, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement A suggested change to improve functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants