fix: held keys are not longer toggled - #9217
Merged
Merged
Conversation
fixes: #7971 suggested by: PseudoResonance #7971 (comment)
Contributor
|
Just for reference, this site is good for testing: https://w3c.github.io/uievents/tools/key-event-viewer.html On the repeated key events, you should see the "repeat" column marked with a checkmark. 
As opposed to just having the key go up/down each time. 
|
Member
Thanks, that was super helpful. |
8 tasks
sithlord48
added a commit
that referenced
this pull request
Nov 30, 2025
nbolton
pushed a commit
that referenced
this pull request
Nov 30, 2025
sithlord48
added a commit
that referenced
this pull request
Nov 30, 2025
nbolton
pushed a commit
that referenced
this pull request
Nov 30, 2025
12 tasks
ljepson
added a commit
to ljepson/deskflow
that referenced
this pull request
Jan 30, 2026
Key repeat from Windows servers wasn't working on macOS because the repeat keystroke paths were disabled for non-Windows (PR deskflow#9217/deskflow#9234) OSXKeyState never set the autorepeat flag on synthetic events Now we enable repeat keystroke generation for macOS alongside Windows, skip repeat key-ups in fakeKey() (matching MSWindowsKeyState behavior), and set kCGKeyboardEventAutorepeat/event.key.repeat so macOS recognizes the events as held keys rather than discrete taps. Fixes deskflow#7971, fixes deskflow#3510
ljepson
added a commit
to ljepson/deskflow
that referenced
this pull request
Jan 30, 2026
Key repeat from Windows servers wasn't working on macOS because the repeat keystroke paths were disabled for non-Windows (PR deskflow#9217/deskflow#9234) OSXKeyState never set the autorepeat flag on synthetic events Now we enable repeat keystroke generation for macOS alongside Windows, skip repeat key-ups in fakeKey() (matching MSWindowsKeyState behavior), and set kCGKeyboardEventAutorepeat/event.key.repeat so macOS recognizes the events as held keys rather than discrete taps. Fixes deskflow#7971, fixes deskflow#3510
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #7971
suggested by: PseudoResonance #7971 (comment)
Tested this on mac os and it was way smoother in game also tested on kde plasma didn't see any change here (it was working for me before and it remains working)