Skip to content

Begin to use QtSsl in more places - #9209

Merged
sithlord48 merged 5 commits into
masterfrom
moreUseofQtSsl
Nov 27, 2025
Merged

Begin to use QtSsl in more places#9209
sithlord48 merged 5 commits into
masterfrom
moreUseofQtSsl

Conversation

@sithlord48

@sithlord48 sithlord48 commented Nov 25, 2025

Copy link
Copy Markdown
Member

Continue to use QNetwork and QSsl in place of just plain SSL

  • Replace Fingerprint::Type -> QCryptographicHash::Algorithm
    • We consider any Algorithm other than Sha1 and Sha256 invalid
  • Move SecureUtils::getCertLength => TlsUtility::getCertKeyLength
    • This method was only called by our TlsUtility
    • TlsUtility uses QSslKey to check the length
  • Remove unused SecureUtils::pemFileCertFingerprint.
  • TlsUtlity::isCertValid no longer considers DSA keys valid
    • We do not generate or use them anywhere but that one check

@sithlord48
sithlord48 requested a review from a team November 25, 2025 15:45
@sithlord48
sithlord48 requested a review from nbolton as a code owner November 25, 2025 15:45
@sithlord48 sithlord48 changed the title More useof qt ssl Begin to use QtSsl in more places Nov 25, 2025
nbolton
nbolton previously approved these changes Nov 25, 2025
View reviewed changes
Comment thread src/lib/net/Fingerprint.cpp Outdated
@sithlord48
sithlord48 requested a review from nbolton November 25, 2025 17:28
@sithlord48
sithlord48 enabled auto-merge (rebase) November 27, 2025 12:48
@sithlord48
sithlord48 merged commit b6bc920 into master Nov 27, 2025
34 checks passed
@sithlord48
sithlord48 deleted the moreUseofQtSsl branch November 27, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton