fix: macOS, crash when log is open and you minimize the gui - #9208
Merged
Conversation
fixes: #9206 on macOS the minimize creates a race to show and hide the log
nbolton
approved these changes
Nov 25, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
This PR fixes the crash, but something still ain't right with show/hide and the log/window size.
Member
Author
|
That only happened to me the one time on mac os then it fixed itself.. i suspect its due to stale geoemtry data that initial time. I do some testing later to make sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #9206
on macOS the minimize creates a race to show and hide the log
To test:
-buttonAfter step 3 there should be no crash with this PR