feat: Configure default screen lock state - #9205
Conversation
There was a problem hiding this comment.
I can't test correctly since on wayland hotkeys dont work (on the server) . with it on i was not able to leave my server so that is good sign that is does work
With this setting enabled when you do move into the client, what happens to the lock ? Can i move from the client back to the server (or another client) without pressing the key again ? Or does this lock again when you cross a screen border.
It should be perpetually locked until a hotkey disables it. However, I'll try testing it again in a bit just to be absolutely sure, because maybe I missed something. |
|
Got ya. |
3dfdc56 to
2f3c63f
Compare
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
Looks good to me we can further improve the Gui if needed after this
Also this is unrelated, but I can't check at the moment. Is the hotkey issue because it only takes control when leaving the screen? Is it also related to why clipboard can't be synchronized from client -> server? (Wayland -> Wayland) I tried switching my server to it yesterday and spent like an hour messing around... Didn't realize it was broken. |
Yup, working as expected. I only have a Windows -> Wayland setup to test, but I was able to start locked, switch screens and stay locked. Then hit an unlock hotkey, and was able to switch screens unlocked. Toggling lock on/off on either screen works as expected too. |
No hotkeys on the wayland server need to be communicated to the server via the hotkey portal. The client just gets faked input so those seam to work (at least last i checked i was able to use scroll lock on a client but not the host). Its an unrelated issue to this PR. #7596 |
nbolton
left a comment
nbolton
left a comment
There was a problem hiding this comment.
LGTM, sorry I'm a bit swamped right now and don't have time to test this one but if @sithlord48 tested then it's fine to land.
2f3c63f to
db1b2d4
Compare
3 participants
Adds toggle option to change the default screen lock state.
Compared to #9201, this allows users to achieve the same result, but also opens the ability to unlock/relock via keybinds if desired.
Fixes: #7907