feat: Force lock to screen option - #9201
Conversation
f847c74 to
2fa0913
Compare
2fa0913 to
c831cc6
Compare
|
This needs to be rebased. also insert translations for all languages using google translate , this will at least give the users a "basic" string until translators check it. I don't like the name for the option its very easy to confuse with the normal screen lock mode. We should think about how to present this to the user maybe even adjust the label shown to the user. Please do not add new commits only add to this one. |
What should it be rebased on? Edit: Nevermind, I see what I did.
I sort of named it as the opposite of the "disable screen lock with scroll lock" option, to contrast it, but yeah the name is weird. Do you have any other ideas for it? |
|
Not at this time but i may when i get to a proper review I wonder if we can somehow combine the two into on option shown to the user |
Yeah, they are kinda mutually exclusive. I just had an idea though, because this entirely disables the whole edge of screen switching feature, would it be better if instead, it just changed the default screen lock state? Then, users may use keybinds to reenable it if desired. |
|
mutally exclusive for sure. Yeah maybe that is better for now we can do Scroll Lock : () Lock to screen : () Release screen lock does this still require the mouse to cross the border when "unlocked" to go to a new screen ? |
Hm, it's late, so maybe I am misunderstanding, but you're suggesting a radio option/select one right? However, the option I added isn't tied to the scroll lock, as it just blocks all "screen edge" switching. It keeps the screen permanently locked, so that only hotkeys allow switching. So when it was unlocked, you could still use hotkeys to swap and stuff too, but had both options. I personally wanted the option for gaming, because relative mouse movements depend on locking, and I could lock with a keybind, but it would be unlocked at boot until I first switched. |
|
Yes radio style boxes. If this just prevents you from leaving the screen what is the point ? you can just use scrool lock when your on the screen w/ your game. Also for me all(?) full screen game lock the mouse to the window and i have to alt+tab to release the mouse. |
I honestly don't remember, but it's happened before, so I figured I'd just get it working properly instead of making huge dead corners or something. I personally only have 2 computers though and a dedicated switch key, so it works well for me. But that's what got me thinking, maybe I don't need it to be forced locked, I just need it to default locked. If lock on scroll lock is false, but it defaults locked, then only a hotkey can let you out? That sounds like maybe a more useful option for everyone? |
|
I could see that being confusing for some that is why we have it off by default and you press to enable it (currently) Yes for your example that may not too bad. we just need to communicate it correctly. |
Yeah I was trying to think of a way that would solve more people's configurations. Perhaps just an option to "Default lock to screen" on/off? "Lock to screen at startup" or something. |
Adds an option to forcefully lock the cursor to the screen (switch by hotkey only), by disabling all screen lock checks.
Fix for #7907