Skip to content

Unify the Tls Utility and Certificate - #9197

Merged
nbolton merged 14 commits into
masterfrom
mergeTlsUtils
Nov 24, 2025
Merged

Unify the Tls Utility and Certificate#9197
nbolton merged 14 commits into
masterfrom
mergeTlsUtils

Conversation

@sithlord48

@sithlord48 sithlord48 commented Nov 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This Pr does a few things but at a high level

  • Move all the functionality of TlsCerfiticate into TlsUtility. Both classes overlap and provide helper when working with our Tls stack
  • Make TlsUtility a namespace deskflow::gui::TlsUtility with a collection of methods useful when working with Tls
  • Check if we have a valid cert via TlsUtility
  • Use Qt to handle the SSL parts in TlsUtility
  • Do not use the LocalFingerprint file just store a copy of the print in our main window
  • Includes ts changes @ykasap @albanobattistella @sailordiary @levpr1c should confirm they are correct.

@sithlord48
sithlord48 requested a review from a team November 22, 2025 17:54
@sithlord48
sithlord48 requested a review from nbolton as a code owner November 22, 2025 17:54
@sithlord48 sithlord48 added the ✨ enhancement A suggested change to improve functionality label Nov 22, 2025
@sithlord48
refactor: new static TlsUtiliy::isCertValid
6df1006
@sithlord48
refactor: remove unused TlsCertificate::isCertificateValid
b79c4fa
@sithlord48
chore: remove unused TlsUtility::persistCertificate
ac17f8e
@sithlord48
refactor: move TlsCertificate::getCertKeyLength -> static TlsUtility:…
a92f9a2 
…:getCertKeyLength
@sithlord48
chore: rename MainWindow::regenerateLocalFingerprints -> MainWindow::…
1e03b22 
…generateCertificate
@sithlord48
refactor: new static TlsUtility::certFingerprint to generate fingerpr…
39b96b5 
…int on the fly
@sithlord48
refactor: MainWindow keep a local copy of the fingerprint
e649e07 
This also makes it so MainWindow does not use the local_fingerprint file
@sithlord48
chore: remove unused TlsCertificate::generateFingerprint
018ff6e
@sithlord48
chore: remove unused Settings::tlsLocalDb we no longer use the local …
ff938c2 
…fingerprint file
@sithlord48
refactor: TlsUtility::generateCertificate() handle all the steps inte…
4dadc10 
…rnally and make method static
@sithlord48
chore: remove unused TlsCertificate class
684f981
@sithlord48 sithlord48 changed the title Update how TlsUtility Update TlsUtility Nov 23, 2025
@sithlord48 sithlord48 changed the title Update TlsUtility Unify the Tls Utility and Certificate Nov 23, 2025
@nbolton
nbolton merged commit 7e278b6 into master Nov 24, 2025
34 checks passed
@nbolton
nbolton deleted the mergeTlsUtils branch November 24, 2025 11:23
@nbolton

nbolton commented Nov 24, 2025

Copy link
Copy Markdown
Member

After landing and working on another PR, I noticed:

[2025-11-24T11:44:34.862] DEBUG: "failed to read RSA or DSA key from certificate file: /home/nick/.config/Deskflow/tls/deskflow.pem"
	/home/nick/Projects/deskflow/src/lib/gui/TlsUtility.cpp:55

TLS still works though 🤷

@sithlord48

sithlord48 commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

that should regen your key if its invalid. if you changed the settings for the key that seams to catch its been invalidaed as well as not being rsa / dsa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

✨ enhancement A suggested change to improve functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton