chore(tr): Add translators as CODEOWNERS for language files - #9183

My issue with this is as code owners they can approve PRs , that is any PR that contains a change to their language file.

I.e we add a new feature with a gui checkbox this added a new string "foobar". they can approve the whole change including any non gui releated logic that was changed.

I would also ask them if they wanto be codeowner of these file and accept responsibility that comes with it.

code owners they can approve PRs , that is any PR that contains a change to their language file.

I added maintainer review requirement to solve this problem; ie you or I have to approve it too as well as them.

I would also ask them if they wanto be codeowner of these file and accept responsibility that comes with it.

Yeah good point. I did think about this but forgot.

@albanobattistella @ykasap @levpr1c @sailordiary Please let me know if you would like to become the code owners for your respective languages. GitHub will request a review from each of you when .ts files change.

Edit: You alone will not be responsible for the whole PR, just the .ts file -- assuming we have setup our branch rules correctly.

Edit: I forgot to say, this may not work as well as we expect, so if it causes issues with landing PRs we will find an alternative solution.

I will continue to update the Spanish with google translate but we should find a native speaker todo it.

@albanobattistella @ykasap @levpr1c @sailordiary Please let me know if you would like to become the code owners for your respective languages. GitHub will request a review from each of you when .ts files change.

Edit: You alone will not be responsible for the whole PR, just the .ts file.

Edit: I forgot to say, this may not work as well as we expect, so if it causes issues with landing PRs we will find an alternative solution.

Gladly

I'm fine with it.

Please let me know @albanobattistella (translations/deskflow_it.ts) and @levpr1c ( translations/deskflow_ru.ts) whether you would like to or would not like to be code owners for these files.

If not, that's totally fine, I'll remove you from proposed CODEOWNERS file change. Just let me know so we can give this idea a try.

Please let me know @albanobattistella (translations/deskflow_it.ts) and @levpr1c ( translations/deskflow_ru.ts) whether you would like to or would not like to be code owners for these files.

If not, that's totally fine, I'll remove you from proposed CODEOWNERS file change. Just let me know so we can give this idea a try.

yes,i wanna be in CODEOWNERS, but if u can add my friend to, he help me with translate

I have no objection to adding your friend when he makes some commits to the language with his account.

I have no objection to adding your friend when he makes some commits to the language with his account.

okay, but he doesn't really use GitHub, so I don't know if he'll even make one commit xD
He literally forgot about his account until I asked him if he had one

okay, but he doesn't really use GitHub, so I don't know if he'll even make one commit xD He literally forgot about his account until I asked him if he had one

Well lets get them to be active. Inactive codeowners are not good to have in a project.

@albanobattistella Rimani solo tu a scegliere se aderire o rinunciare al ruolo di code owner. Facci sapere.

@albanobattistella Rimani solo tu a scegliere se aderire o rinunciare al ruolo di code owner. Facci sapere.

No response yet, so I'll remove @albanobattistella from this PR tomorrow morning and open the PR for approval.

@albanobattistella Rimani solo tu a scegliere se o ad ordinazione di ordine del codice proprietario. Facci. Sapolo.

Nessuna risposta ancora, quindi rimuoverò @albanobattistella da questo PR domani mattina e aprirò le pubbliche relazioni per l'approvazione.

OK..I'm available...for help on it language. I'm sorry for the late response.

OK..I'm available...for help on it language. I'm sorry for the late response.

No problem. Would you mind opening a PR to add yourself?