Save the Gui state in another file - #9145
Merged
Merged
Conversation
sithlord48
force-pushed
the
guiState
branch
2 times, most recently
from
November 11, 2025 20:42
cc1f080 to
aa755c3
Compare
sithlord48
changed the title
nbolton
reviewed
Nov 13, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
The window size doesn't appear to be restored for me.
Member
Author
|
Odd what did you test on ? I tried on kde w/o issue. |
Member
Both GNOME and KDE.
Expected: Window size restored |
Member
Author
|
Do you have a ~/.local/state directory can you see in it a |
Member
Author
|
The tests were resetting the state file to fix this all tests using setting must also set the state file to be used. |
sithlord48
marked this pull request as ready for review
November 13, 2025 21:30
nbolton
previously approved these changes
Nov 14, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
Window restore works now, but there's a small improvement you could make if you feel like it.
nbolton
approved these changes
Nov 14, 2025
…nce when checking
sithlord48
enabled auto-merge (rebase)
November 14, 2025 14:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9132
Saves the geometry to a state file on every os under
$XDG_STATE_HOME/Deskflow.stateORQStandardPaths::GenericStatePath/Deskflow.stateunless in portable mode then it just uses the normal settings file.Also fixes a bug where we were not restoring the window size when it was hidden to the tray .