Skip to content

Feat: Add Milliseconds to log time - #9113

Merged
sithlord48 merged 12 commits into
masterfrom
loggerUnused
Nov 4, 2025
Merged

Feat: Add Milliseconds to log time#9113
sithlord48 merged 12 commits into
masterfrom
loggerUnused

Conversation

@sithlord48

@sithlord48 sithlord48 commented Nov 4, 2025

Copy link
Copy Markdown
Member
  • Modifiers the Logger

    • remove unused Logger:m_verbose and related method
    • directly set Logger::m_debug using when in debug mode
    • Logger::instance return a pointer to the logger static object
    • use QStringLiterals
    • Logger::PrintLine use less streams and use the one we need directly
  • Remove unused

    • remove unused MainWindow::getTimeStamp
    • AboutDialog remove unneeded includes
  • Modify the Log

    • Log::makeMessages use QDateTime to get current Time
    • Log remove unneeded includes
  • Feat: Show milliseconds in time values (fixes Add millis to log lines for tracking down bugs between client/server #7861)

    • Sets both the Logger and Log to use Qt::IsoDateWithMs for the time format

@sithlord48
sithlord48 requested a review from nbolton as a code owner November 4, 2025 02:35
@sithlord48 sithlord48 linked an issue Nov 4, 2025 that may be closed by this pull request
@sithlord48
sithlord48 force-pushed the loggerUnused branch 6 times, most recently from d43724a to 47d6ba5 Compare November 4, 2025 04:11
Comment thread src/lib/base/Log.h Outdated
nbolton
nbolton previously approved these changes Nov 4, 2025

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!

It's funny, I was literally thinking about doing this the other day. You must be a mind reader. Many times I have needed ms in the timestamp to debug issues where timing is an important factor, and I never got round to adding it.

@sithlord48
sithlord48 merged commit 6c8c6f5 into master Nov 4, 2025
34 checks passed
@sithlord48
sithlord48 deleted the loggerUnused branch November 4, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add millis to log lines for tracking down bugs between client/server

2 participants