Fix 9047 - #9091
Merged
Merged
Conversation
nbolton
approved these changes
Oct 29, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
Wonderful PR! ❤️ ❤️ ❤️
I have been meaning to try SSL_OP_IGNORE_UNEXPECTED_EOF for a long time (time has not been on my side). I wondered if it was the right thing to do, but fixes the bug on macOS so I'm happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9047
Tell SSL to ignore EOF errors from openSSL. These happen when peer disconnects sometimes. Its only ever a close connection error.
Remove the
RetryOnErroroptionCurrently, RetryOnError is set false if the client disconnects and there is no way to change it without editing the config file manually