fix: [build]Fix build issue without format support - #9065
Conversation
|
Fix build issue #9064, the format checking output: |
sithlord48
left a comment
There was a problem hiding this comment.
With all of these having an alt path do we even really need to use format at this point ?
I guess it is mainly used for Log, such as using fmt in spdlog to format the log and get better performance. |
|
In principle, I think this is a good patch and I wonder how it fits long-term with our Qt strategy.
Are you thinking we may be better off switching to Qt equivalent to remove the IIRC, |
|
If we want to move to #8483 using Qt then we don't need format do we ? even with out if we have a fallback do we really require fmt or was it just easier for who ever wrote it at that time. |
IIRC, I was trying to modernise the part of the code that used Anyway, switching to however Qt does it seems sane; std C++ is a bit of a nightmare for consistency across platforms, which is something Qt does really well. |
|
should try format on mac os and see if it works now |
add C++20 <format> support checks in Unix libraries and update logging format usage. Log: Fix build issue without format support.
fixes: #9064
add C++20 support checks in Unix libraries and update logging format usage.
Log: Fix build issue without format support.