Skip to content

fix: dangling pointer from scoped var - #9055

Merged
nbolton merged 1 commit into
deskflow:masterfrom
enzious:fix/dangling-token-pointer
Oct 21, 2025
Merged

fix: dangling pointer from scoped var#9055
nbolton merged 1 commit into
deskflow:masterfrom
enzious:fix/dangling-token-pointer

Conversation

@enzious

@enzious enzious commented Oct 18, 2025

Copy link
Copy Markdown
Contributor

Fixes a bug where token is reported as an invalid UUID.

image

@sithlord48

Copy link
Copy Markdown
Member

Can't wait to be done w/ libportal ...

@sithlord48

Copy link
Copy Markdown
Member

This seams to fix #9030 at least i don't see the crash with it as often.

I have an issue when using this (that also could happen on master but hard to tell as on master its a crash )

On my wayland client (kde debian 13) once i connect i get the box to allow access. then i accept it and can use the screen. If i restart the server (with the restart button on the gui) it connects back up but if i stop the server count to three then restart start it the client asked for portal permission again.

@sithlord48
sithlord48 requested a review from nbolton October 18, 2025 19:05
@enzious

enzious commented Oct 18, 2025

Copy link
Copy Markdown
Contributor Author

I'm not experiencing that issue on my Arch/KDE client 🤔

@sithlord48

Copy link
Copy Markdown
Member

Tested on arch client and not issue. Again i doubt it has todo with this pr anyway . .

@sithlord48 sithlord48 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on arch kde client , no more crashes when disconnecting may help w/ #9030 for EI screens at least.

@nbolton nbolton mentioned this pull request Oct 21, 2025
8 tasks
@nbolton

nbolton commented Oct 21, 2025

Copy link
Copy Markdown
Member

This seams to fix #9030 at least i don't see the crash with it as often.

Seeing the same; fixes it for me too. Nice!

@nbolton
nbolton merged commit ea7a493 into deskflow:master Oct 21, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants