Skip to content

Sonar cleanup 20 - #9048

Merged
nbolton merged 8 commits into
masterfrom
sonarCleanup_20
Oct 17, 2025
Merged

Sonar cleanup 20#9048
nbolton merged 8 commits into
masterfrom
sonarCleanup_20

Conversation

@sithlord48

@sithlord48 sithlord48 commented Oct 15, 2025

Copy link
Copy Markdown
Member

Resolve some sonar issues , clean up more items

  • Define <=> op for EiScreen::HotKeyItem
  • Remove unnneed semi-colons (mostly after namespace brackets)
  • ArchNetworkBsd: Set add to nullptr when cleaning up previous address returning the pointer value.
  • Use QString::first(n) in place of QString::mid(0, n)
  • Remove unused method parameter names from overloaded methods in sub classes.
  • set (and use) CPACK_PROJECT_HOMEPAGE_URL
  • update the pkgbuild to be more like deskflow-git's
  • use Settings::settingsFile() in place of instance()->m_settingsFile

@sithlord48
sithlord48 marked this pull request as ready for review October 15, 2025 19:04
@sithlord48
sithlord48 requested a review from nbolton October 15, 2025 19:04
@nbolton
nbolton enabled auto-merge (rebase) October 17, 2025 07:59
@nbolton
nbolton merged commit 55a9596 into master Oct 17, 2025
29 of 30 checks passed
@nbolton
nbolton deleted the sonarCleanup_20 branch October 17, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants