fix: apply scroll lock setting on initialization - #9043
Merged
sithlord48 merged 1 commit intoOct 17, 2025
Conversation
nbolton
force-pushed
the
fix/scroll-lock-setting-not-applied
branch
from
October 15, 2025 13:36
1dd86c1 to
cc59917
Compare
sithlord48
force-pushed
the
fix/scroll-lock-setting-not-applied
branch
from
October 15, 2025 13:39
cc59917 to
b39a5d0
Compare
sithlord48
enabled auto-merge (rebase)
October 15, 2025 13:39
nbolton
requested changes
Oct 15, 2025
sithlord48
disabled auto-merge
October 15, 2025 13:48
Contributor
Author
|
Dang, I butchered that commit text. The enter key is way to close to backspace. |
sithlord48
requested changes
Oct 15, 2025
enzious
force-pushed
the
fix/scroll-lock-setting-not-applied
branch
from
October 15, 2025 18:08
cb7ceb5 to
28136f1
Compare
sithlord48
requested changes
Oct 15, 2025
sithlord48
left a comment
sithlord48
left a comment
Member
There was a problem hiding this comment.
Please do not fix staged commits with new commits. (i.e your 3rd commit should be part of where the warning was created.)
enzious
force-pushed
the
fix/scroll-lock-setting-not-applied
branch
from
October 15, 2025 22:01
28136f1 to
9314a26
Compare
Contributor
Author
|
I'm assuming you mean squash the commits... sorry |
sithlord48
approved these changes
Oct 15, 2025
Member
|
I did not just that you should have made the correction part of the commit where it was first created not an additional commit. The squash works here as well. Thanks for the Fix ! |
sithlord48
enabled auto-merge (rebase)
October 15, 2025 22:10
Member
|
@enzious does this fix any open issues ? |
Contributor
Author
Not that I could find |
Co-authored-by: Nick Bolton <[email protected]>
sithlord48
force-pushed
the
fix/scroll-lock-setting-not-applied
branch
from
October 16, 2025 15:57
9314a26 to
d81fa16
Compare
sithlord48
disabled auto-merge
October 16, 2025 15:57
sithlord48
enabled auto-merge (rebase)
October 16, 2025 15:58
nbolton
approved these changes
Oct 17, 2025
Member
|
A couple of things I noticed while testing this fix:
|
Member
|
Hotkeys wont work on wayland until we impliment the hotkey portal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes small issue with scroll lock setting not being applied on initialization. Also added a log for when no barriers are found.