deskflow-core remove non essential options - #9040
Merged
Merged
Conversation
sithlord48
changed the title
…d CoreArgParse to apps/deskflow-core
sithlord48
force-pushed
the
simplifyCoreArgs
branch
from
October 15, 2025 13:48
9a995e0 to
61fb09e
Compare
nbolton
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As talked about in #9032 ,
replaces: #9032
Remove all non essential options from
deskflow-core. All settings must be set in the settings (manually) or bydeskflow-guibefore launching thedeskflow-core.deskflow-coreWill read all settings from the file loaded with -sOnly
-h--helpused to generate man and list valid options / use-v--versionreport the version (as used for man)-s--settingsSettings file to useMove
CoreArgsandCoreArgParsetoapps/deskflow-coreRemove
CoreArgsParserTestswith our simple args there is no need to test themPrint any errors from the core arg parser but do not abort the app only print them.
While reviewing check if any of the removed settings must be set by the user and are missing from the settings dialog if any are found an issue should be made so we can add them to the settings dialog.