Core process cleanup - #9023
Merged
Merged
Conversation
sithlord48
force-pushed
the
coreProcessCleanup
branch
3 times, most recently
from
October 11, 2025 00:57
5e9fe40 to
57cf3d8
Compare
nbolton
requested changes
Oct 13, 2025
sithlord48
force-pushed
the
coreProcessCleanup
branch
from
October 13, 2025 11:32
57cf3d8 to
8716bc2
Compare
sithlord48
force-pushed
the
coreProcessCleanup
branch
from
October 13, 2025 11:50
8716bc2 to
6ff10ef
Compare
…simplify logic in the loop
…nused addClientArgs , and args parameter from addServerArgs
… when checking if server
…toString().toLower() to create the string, make method static member of CoreProcess
…o string, make static member of CoreProcess
… dir in start if needed
…others via CoreProcess::coreProcessStateChanged
… place of constructing in CoreProcess
sithlord48
force-pushed
the
coreProcessCleanup
branch
from
October 13, 2025 12:16
6ff10ef to
804a22e
Compare
nbolton
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #9022 and #9001
Clean up
CoreProcessCoreProcessCoreProcess::modeString()CoreProcess::processModeString()CoreProcess::correctedAddressinCoreProcess::setAddressCoreProcess::wrapIpv6and make it static member ofCoreProcessCoreProcess::startedsignal handle viaCoreProcess::coreProccessStateChangedCoreProcess::startCoreProcess::startCoreProcess:persistLogDir()handle in start when needed.CoreProcess::startmakeQuotedArgsa private member ofCoreProcessprocessStateToStringa private member ofCoreProcessprocessModeToStringa private member ofCoreProcessCoreProcess::makeQuotedArgs.Simplifybefore appending any items to the quoted list.then wrap in quotes unless it already is wrapped in quotesCoreProcess::restart