Skip to content

Core process cleanup - #9023

Merged
sithlord48 merged 19 commits into
masterfrom
coreProcessCleanup
Oct 13, 2025
Merged

Core process cleanup#9023
sithlord48 merged 19 commits into
masterfrom
coreProcessCleanup

Conversation

@sithlord48

@sithlord48 sithlord48 commented Oct 10, 2025

Copy link
Copy Markdown
Member

replaces #9022 and #9001
Clean up CoreProcess

  • CoreProcess::Start return early if
    • Process is already started
    • Invalid mode
  • Use QVariant to generate strings for enums
  • Remove unused Includes in CoreProcess
  • Remove CoreProcess::modeString()
  • Remove CoreProcess::processModeString()
  • Use CoreProcess::correctedAddress in CoreProcess::setAddress
  • Simplify CoreProcess::wrapIpv6 and make it static member of CoreProcess
  • Remove CoreProcess::started signal handle via CoreProcess::coreProccessStateChanged
  • Move all the arg setting in CoreProcess to CoreProcess::start
    • Set Log in CoreProcess::start
    • Remove CoreProcess:persistLogDir() handle in start when needed.
    • remove `CoreProcess::addClientArgs()
    • remove `CoreProcess::addServerArgs()
      • handle setting of server config info in CoreProcess::start
  • Make the function makeQuotedArgs a private member of CoreProcess
  • Make the function processStateToString a private member of CoreProcess
  • Make the function processModeToString a private member of CoreProcess
  • Simplify the method CoreProcess::makeQuotedArgs.
    • Call Simplify before appending any items to the quoted list.
    • If an item contains then wrap in quotes unless it already is wrapped in quotes
  • Simplify CoreProcess::restart

@sithlord48
sithlord48 requested a review from nbolton October 10, 2025 20:13
@sithlord48 sithlord48 added this to the v1.25.0 milestone Oct 10, 2025
@sithlord48 sithlord48 added the 🗒️ task Doesn't directly add new functionality or fix bugs in the program label Oct 10, 2025
@sithlord48
sithlord48 force-pushed the coreProcessCleanup branch 3 times, most recently from 5e9fe40 to 57cf3d8 Compare October 11, 2025 00:57
Comment thread src/lib/gui/core/CoreProcess.cpp Outdated
…nused addClientArgs , and args parameter from addServerArgs
…toString().toLower() to create the string, make method static member of CoreProcess
…others via CoreProcess::coreProcessStateChanged
@sithlord48
sithlord48 enabled auto-merge (rebase) October 13, 2025 12:20
@sithlord48
sithlord48 merged commit 2b203c8 into master Oct 13, 2025
30 checks passed
@sithlord48
sithlord48 deleted the coreProcessCleanup branch October 13, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗒️ task Doesn't directly add new functionality or fix bugs in the program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants