SonarScanner cleanup - #9015
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
43c4950 to
8354f9d
Compare
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
No reason to change the quotes.
I do not like this as its own yml now we have 3 action runs per push.. Making it harder to find the action i care about with the build results.
The matrix expands, so there are actually dozens. Adding 1 more makes little difference, plus it's at the bottom. By running a workflow from a workflow like this, we're fighting convention which will only confuse others in future. It's also a stumling block when you're exploring the code scanning UI in GitHub, as it appears that the workflow is not running (untill you unpick the fact that it's called from another workflow). The GitHub UI just isn't designed for this and it makes little sense fighting it for the sake of 1 less row in a list of like 30(?) results. |
I'm talking about the Action list when we go look for jobs related to the CI runs 
|
Even so, adding 1 more doesn't make much difference and significantly reduces confusion in other areas of the GitHub UI such as the "View runs" button on the workflow (edit: and the badge on our readme). When you run a workflow from a workflow, it doesn't show up as a run on the workflow, so it looks like the workflow is not running (after paging out the fact that it's a workflow running from a workflow). 
It's unconventional to run code scanning workflows from within a workflow within a workflow, which makes it confusing when trying to find the results in the GitHub UI. When you fight against the GitHub UI, you make life harder for others. |
|
It's more an issue with my workflow and how I like to see the actions... I'm sure ill get over it. |
8354f9d to
6edf20d
Compare
af53287 to
1644939
Compare
fix: Prevent SonarCloud analysis from running on draft pull requests
refactor: Rename job from 'sonarcloud-analysis' to 'analyze' in SonarCloud workflow refactor: Reorder SonarQube scan and build wrapper installation steps in SonarCloud workflow refactor: Update SonarQube scan step to use new action and streamline options fix: Update SonarQube scan step to correctly pass coverage report paths and environment variables fix: Set CPU core count to a fixed value in SonarCloud analysis workflow refactor: Move 'Install Build Wrapper' step to the correct position in the SonarCloud analysis workflow refactor: Remove unused Sonar Scanner environment variables from analysis workflow
1644939 to
ddd6c2f
Compare
3 participants
Fixes #8138
Todo: