Skip to content

App cleanup unused args - #8991

Merged
nbolton merged 6 commits into
masterfrom
appCleanup
Oct 7, 2025
Merged

App cleanup unused args#8991
nbolton merged 6 commits into
masterfrom
appCleanup

Conversation

@sithlord48

@sithlord48 sithlord48 commented Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • Remove the argc and argv from various app and IApp methods.

Should check this with windows daemon

@sithlord48
sithlord48 force-pushed the appCleanup branch 5 times, most recently from 0e61458 to 8ad3bbb Compare October 1, 2025 14:56
@sithlord48
sithlord48 requested a review from nbolton October 1, 2025 14:56
@sithlord48
sithlord48 marked this pull request as ready for review October 1, 2025 14:56
@nbolton

nbolton commented Oct 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Saw this on macOS while testing, but as I've been OOO for a week this could be in master:

[2025-10-06T10:17:20] WARNING: desktop process exited with code: 3
	/Users/nick-symless/Projects/deskflow/src/lib/gui/core/CoreProcess.cpp:195
[2025-10-06T10:17:21] INFO: starting core client process (desktop mode)
	/Users/nick-symless/Projects/deskflow/src/lib/gui/core/CoreProcess.cpp:326
[2025-10-06T10:17:21] INFO: running command: /Users/nick-symless/Projects/deskflow/build/bin/Deskflow.app/Contents/MacOS/deskflow-core client
	/Users/nick-symless/Projects/deskflow/src/lib/gui/core/CoreProcess.cpp:232
2025-10-06 10:17:21.451274+0100 deskflow-core[13900:146306] settings file: /Users/nick-symless/Library/Deskflow/Deskflow.conf
[2025-10-06T10:17:21] FATAL: deskflow-core: unrecognized log level `'
Try `deskflow-core --help' for more information.
	/Users/nick-symless/Projects/deskflow/src/lib/deskflow/App.cpp:147
[2025-10-06T10:17:21] WARNING: desktop process exited with code: 3
	/Users/nick-symless/Projects/deskflow/src/lib/gui/core/CoreProcess.cpp:195
[2025-10-06T10:17:22] INFO: starting core client process (desktop mode)
	/Users/nick-symless/Projects/deskflow/src/lib/gui/core/CoreProcess.cpp:326
[2025-10-06T10:17:22] INFO: running command: /Users/nick-symless/Projects/deskflow/build/bin/Deskflow.app/Contents/MacOS/deskflow-core client
	/Users/nick-symless/Projects/deskflow/src/lib/gui/core/CoreProcess.cpp:232
2025-10-06 10:17:22.478954+0100 deskflow-core[13903:146319] settings file: /Users/nick-symless/Library/Deskflow/Deskflow.conf
[2025-10-06T10:17:22] FATAL: deskflow-core: unrecognized log level `�'
Try `deskflow-core --help' for more information.

Edit: Yes, this is in master. I will raise a bug.

@sithlord48

sithlord48 commented Oct 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

^ already reported by #8999 ( fixed by #8997 )

@nbolton

nbolton commented Oct 7, 2025

Copy link
Copy Markdown
Member

Should check this with windows daemon

Blocked by #8998

@nbolton

nbolton commented Oct 7, 2025

Copy link
Copy Markdown
Member

Should check this with windows daemon

Blocked by #8998

Actually, I was able to run the daemon from Windows services so I believe that's good enough to test this PR:

Deskflow Daemon v1.24.0.71 (96db0980)
[2025-10-07T12:49:36] NOTE: starting daemon
[2025-10-07T12:49:36] INFO: daemon is running

@nbolton
nbolton enabled auto-merge (rebase) October 7, 2025 11:51
@nbolton
nbolton merged commit 8ea2671 into master Oct 7, 2025
30 of 31 checks passed
@nbolton
nbolton deleted the appCleanup branch October 7, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton