Set app id via registry portal - #8988
Merged
Merged
Conversation
sithlord48
force-pushed
the
setAppIdViaRegistryPortal
branch
4 times, most recently
from
September 30, 2025 01:48
8692796 to
83fd1c0
Compare
sithlord48
force-pushed
the
setAppIdViaRegistryPortal
branch
from
September 30, 2025 02:08
83fd1c0 to
52594a2
Compare
nbolton
approved these changes
Sep 30, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
LGTM, nice refactor too 👍
OOO, can't test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #8869
It turns out we did not quite finish the restore part when running from outside a sandboxed deployment (i.e flatpak)
flatpakorsnapxdg-registry-portalto set the app id. when not in a sandboxCMAKE_PROJECT_FQDN_NAMEto use for the fully reverse domain name (i.e org.deskflow.deskflow) set it on constants.h use it where were used to use the string directly.