fix: Do not reuse listen sockets on Windows - #8979
Merged
Merged
Conversation
nbolton
marked this pull request as ready for review
September 25, 2025 12:35
nbolton
enabled auto-merge (rebase)
September 25, 2025 12:35
sithlord48
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8978
Apparently, this is common practice on Unix to allow fast process restart and is needed because of
TIME_WAIT(I didn't test this). It appears this pattern was copied to the Windows implementation, but that is not advisable for Windows sockets since they don't behave the same.