fix: support 'xrandr --panning' - #8963
Conversation
|
oh, and FYI, #8867 breaks stuff: #8867 (comment) |
|
I do not really have a way to test this... @nbolton can you test this ? |
|
FYI: logging breakdown by this PR with client:2 FullHD outputs, left one (monitor) is overlapping right one (TV) and can pan onto it to check what's there server:center is a bit wrong on server - i enlarged one output to Y:1920 (by $ xrandr
Screen 0: minimum 320 x 200, current 2560 x 1440, maximum 16384 x 16384
HDMI-2 connected 2560x1920+0+0 (normal left inverted right x axis y axis) 408mm x 306mm
1600x1200 59.81*+
DVI-I-1-0 connected primary 2560x1440+0+0 (normal left inverted right x axis y axis) 597mm x 336mm
2560x1440 59.95*+maybe another PR in future: needs some XRandr checks probably, or root window. but i doubt there are many users with such weird config p.s.: it's called X11 Window System, not XWindows, lol |
Not that this has anything todo with the pr, but It's name is the |
964f9d3 to
c81d52e
Compare
|
When you are ready for this to be reviewed please un draft . |
c81d52e to
5946751
Compare
|
This needs to be rebased on the master branch please do that also . |
|
CI wanted 4 lines instead of a single one - rebased again and applied patch marking as ready |
this allows screens to overlap, use panning, etc
…ving screen panned screens still needs `xtestIsXineramaUnaware` option enabled. this change forcefully uses XTest only when leaving useful examples: * double 1 FullHD screen (main output) by: `xrandr --fb 3840x1080 --output DP-1 --panning 3840x1080+0+0/3840x1000+0+80`, leaving top 80 pixels for moving mouse out without actual panning * dedicate right half of framebuffer to FullHD TV (second output): `xrandr --fb 3840x1080 --output HDMI-0 --panning 1920x1080+1920+0`
5946751 to
4f7ea1c
Compare
|
oops, rebased correctly |
|
I can test to make sure this does not break my normal X session but i do not have a setup w/ panning to test that. |
you mean server side session? |
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
Tested on Kde X11 session as both client and host seams to at least not break "normal" use
nbolton
left a comment
nbolton
left a comment
There was a problem hiding this comment.
Changes look reasonable. I'd love to test, but I'm a bit short on time right now.
3 participants
hey guys! thanks for the nice software, here's my 2 cents...
i've been testing this for a week+ already - works great, just recompiled against
v1.24.0- no issueswould love to hear if this also works for real xinerama user (not xrandr!) user: multi-gpu, different screens, very complex config ;p
please review