Conversation
Was returning only first char of error message (mild-mojibake)
Prevents high CPU usage while waiting for data (ERROR_NO_DATA)
Member
|
Approve if you have checked this is fixing the bug for you. |
sithlord48
approved these changes
Sep 12, 2025
sithlord48
left a comment
sithlord48
left a comment
Member
There was a problem hiding this comment.
One day all our strings will be QStrings . Nice work !
Member
Author
Edit: Ah, I was running This was master: And this is my PR: |
nbolton
marked this pull request as draft
September 12, 2025 12:14
nbolton
marked this pull request as ready for review
September 12, 2025 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8946
I ❤️ QString