fix: wayland sleep inhibit on client - #8947
Conversation
Fixes deskflow#8827 Adds the XWindowsPowerManager to the EiScreen as, despite the name, this works on Wayland as well.
There was a problem hiding this comment.
Working nicely. And wow that was simpler than I expected. As I mentioned on the issue, we should rename the power manager, but in a separate PR:
Thinking about it, would the XWindowsPowerManager code work for Wayland or is org.freedesktop.ScreenSaver X11 specific? If not, the class name is a bit silly. Maybe it should be renamed to something else.
#8827 (comment)
Edit: Raised #8949
|
OOC, is there any update on when this ships on Synergy? Was about to open an issue as this seems to be a bug on Wayland (possibly due to lack of system-inhibits call) and saw this got merged. Apologies for the noise :) |
|
No Idea, I think the proper place to ask about synergy is within one of their support places. Don't take that as me being upset you asked or anything. I only want to direct question to the proper place. Deskflow is not Synergy. Symless can take what they do or don't want (or anyone really as long as the license is followed) so its hard for us (deskflow) to say what another group might do with the code and in what kind of time frame. I know that Nick (who is an active contributor) will also very likely answer your question here. It may not always be the case we have someone from the specific downstream your asking about active enough here to answer. |
|
Absolutely fair answer, will do a support ticket on Synergy then :) |
It was backported in symless/synergy#123 and released in v1.19.0. Thanks for being a customer! Edit: Also, v3.4.0 includes the Core from v1.19.0, so the fix should be there. If you're still seeing problems, then please open a support ticket. |
|
Cool! Waiting for it to reach on Synergy 3 (also apologies for the off topic) |
4 participants
Fixes #8827
Adds the XWindowsPowerManager to the EiScreen as, despite the name, this works on Wayland as well.
Tested on KDE and shows the inhibit in the power menu when the client connects successfully.
I believe this change is small enough to not need copyright updates or doco changes (as this actually brings inline with doco rather than adding anything) - but let me know if you want me to update it.
I also decided that renaming XWindowsPowerManager is probably not worthwhile as part of this change, but again if that's preferred, happy to do so.
I do not have access to a windows or OSX machine to test, but given the EiScreen is Linux only I don't believe this will be an issue.