Skip to content

fix: Store server config window state in memory instead of on disk - #8935

Merged
sithlord48 merged 1 commit into
masterfrom
server-config-visible
Oct 13, 2025
Merged

fix: Store server config window state in memory instead of on disk#8935
sithlord48 merged 1 commit into
masterfrom
server-config-visible

Conversation

@nbolton

@nbolton nbolton commented Sep 10, 2025

Copy link
Copy Markdown
Member

Fixes #8931

@nbolton
nbolton requested a review from sithlord48 September 10, 2025 08:41
@sithlord48

sithlord48 commented Sep 10, 2025

Copy link
Copy Markdown
Member

I forget why (and it could be something we have since fixed) But not storing this as a setting was preventing it from not being shown in some cases. This needs to be tested thoroughly before landing

@sithlord48
sithlord48 force-pushed the server-config-visible branch from e8c382d to 9560a88 Compare September 10, 2025 12:47
@nbolton

This comment was marked as outdated.

@nbolton

nbolton commented Sep 10, 2025

Copy link
Copy Markdown
Member Author

Ignore my last comment.

preventing it from not being shown in some cases

Hmm, something like a race condition from the server config being non-blocking once upon a time?

@sithlord48

Copy link
Copy Markdown
Member

Ignore my last comment.

preventing it from not being shown in some cases

Hmm, something like a race condition from the server config being non-blocking once upon a time?

Yes something like that i just don't recall exactly what or why it happened. Just that the solution was at that time to have them both check settings first. Its a hack and it should be done how you are doing it here. So hopefully we have resolved it

@sithlord48
sithlord48 force-pushed the server-config-visible branch 3 times, most recently from 6b00866 to 2f1cf8a Compare September 12, 2025 17:08
@sithlord48 sithlord48 added the 🩹 fix This PR fixes a reported bug label Sep 12, 2025
@nbolton
nbolton force-pushed the server-config-visible branch 3 times, most recently from 81d3d34 to 183c030 Compare October 13, 2025 12:24
@sithlord48
sithlord48 force-pushed the server-config-visible branch from 183c030 to 5dbc86d Compare October 13, 2025 12:34
@sithlord48
sithlord48 enabled auto-merge (rebase) October 13, 2025 12:39
@sithlord48
sithlord48 merged commit 0f335d4 into master Oct 13, 2025
30 checks passed
@sithlord48
sithlord48 deleted the server-config-visible branch October 13, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🩹 fix This PR fixes a reported bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept client prompt not showing on Windows server

2 participants