Minor tweaks to std::mutex uses - #8922
Merged
Merged
Conversation
Member
|
please use |
sithlord48
requested changes
Sep 4, 2025
sithlord48
left a comment
sithlord48
left a comment
Member
There was a problem hiding this comment.
Looks ok need updates to the commit messages.
The `static` keyword was removed by deskflow#8674 but I think it should be restored so that this global can't clash with anything else called `::s_mutex` elsewhere in the executable.
There's no need to hold the mutex while constructing a `std::string` from the `char` string. Also use `inet_ntop` instead of the potentially thread-unsafe `inet_ntoa` that might use a static buffer for the result. This makes the `INet` case match the `INet6` case below.
sithlord48
approved these changes
Sep 4, 2025
nbolton
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing my comments on #8674
POSIX says to prefer
inet_ntoptoinet_ntoaeven for IPv4 because it's thread-safe.https://pubs.opengroup.org/onlinepubs/9799919799/functions/inet_ntoa.html