Skip to content

Better log dock - #8921

Merged
nbolton merged 2 commits into
masterfrom
betterLogDock
Sep 11, 2025
Merged

Better log dock#8921
nbolton merged 2 commits into
masterfrom
betterLogDock

Conversation

@sithlord48

@sithlord48 sithlord48 commented Sep 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • Split the LogDock into its own item
  • Allow the Log dock to float or be attached to the bottom (dock will always start docked on to the bottom)
  • Added icons window-restore-pip, window-minimize-pip and view-close
  • Use new window icons for our minimize and restore deskflow actions.

@sithlord48
sithlord48 requested a review from nbolton September 4, 2025 03:49
sithlord48
sithlord48 commented Sep 4, 2025
View reviewed changes
Comment thread src/lib/gui/widgets/LogDock.cpp Outdated
@sithlord48
sithlord48 force-pushed the betterLogDock branch 2 times, most recently from 5370721 to 8447a94 Compare September 4, 2025 04:27
@nbolton

nbolton commented Sep 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

My help w/ weird sizing on GNOME ?

Similar issues on GNOME. This is what it looks like when I detach the log.

image

@nbolton

nbolton commented Sep 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

The icons look a bit too big on Windows.

image

Edit: And the macOS icons look OK, but don't match Linux.

Screenshot 2025-09-04 at 09 31 10

nbolton
nbolton previously approved these changes Sep 4, 2025
View reviewed changes
@sithlord48

sithlord48 commented Sep 4, 2025

Copy link
Copy Markdown
Member Author

The icons should be platform native. But looking at how windows picks the "refresh" icon.. I ll have to at least pack an icon for windows at least. Do you have "breeze" theme installed on your gnome machine ? if yoru not using breeze theme do you get an icon in gnome?

@sithlord48

sithlord48 commented Sep 4, 2025

Copy link
Copy Markdown
Member Author

@nbolton thoughts on remove the whole logic for fixed window sizing at least then users can make the window smaller if it does this kinda stuff.

@sithlord48
sithlord48 requested a review from nbolton September 4, 2025 13:43
@sithlord48
sithlord48 force-pushed the betterLogDock branch 2 times, most recently from 21d175f to 771f101 Compare September 4, 2025 13:47
@nbolton

nbolton commented Sep 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Do you have "breeze" theme installed on your gnome machine ? if yoru not using breeze theme do you get an icon in gnome?

Breeze detach is always white, so invisible in light mode.

image
image
image

@nbolton

nbolton commented Sep 4, 2025

Copy link
Copy Markdown
Member

remove the whole logic for fixed window sizing

For me personally, I'm happy as long as I can resize it and it remembers what size I made it.

nbolton
nbolton reviewed Sep 4, 2025
View reviewed changes
Comment thread src/lib/gui/widgets/LogDock.cpp
@sithlord48

sithlord48 commented Sep 4, 2025

Copy link
Copy Markdown
Member Author

breeze is the "light" color theme "breeze-dark" would have the icons from dark schemes

@sithlord48
sithlord48 requested a review from nbolton September 4, 2025 16:27
@nbolton

nbolton commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

breeze is the "light" color theme "breeze-dark" would have the icons from dark schemes

Indeed, though that doesn't explain why the icon is white when using light mode style (i.e. regular Breeze). The screenshot is confusing as our GUI uses GNOME legacy style (not modern dark mode).

image

@github-actions

This comment was marked as outdated.

Sign in to view
@sithlord48

sithlord48 commented Sep 9, 2025

Copy link
Copy Markdown
Member Author

I Tested on Debian 13 with GNOME 48 unable to repo that icon issue.

@nbolton

nbolton commented Sep 10, 2025

Copy link
Copy Markdown
Member

I Tested on Debian 13 with GNOME 48 unable to repo that icon issue.

OK, I'll test on a VM. Maybe my "default" GNOME Tweak settings are not actually default.

@sithlord48
sithlord48 force-pushed the betterLogDock branch 2 times, most recently from 6b9af57 to 836e368 Compare September 10, 2025 13:43
@nbolton

nbolton commented Sep 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Yeah, looks fine on stock Debian 13.

Screenshot_debian-13_2025-09-11_10:55:13

Maybe my "default" GNOME Tweak settings are not actually default.

I'll chalk that up to experience I guess... GNOME.

@nbolton
nbolton merged commit 949f1d6 into master Sep 11, 2025
31 checks passed
@nbolton
nbolton deleted the betterLogDock branch September 11, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton