feat: Add switchToNextScreen hotkey to cycle through computers - #8904
Conversation
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
Overall looks ok need to split your fix into its own commit.
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
Just some things:
You should start the commits message with fix: and feat: (must be lowercase and have the :)
The commits here are not in order and are broken up incorrectly (for us)
Lets get this commits fixed you have two commits here (in this order if you don't mind)
- fixes the mouse label issue (changes to Action.cpp)
- The rest that adds the feature (documentation etc is added in the same commit)
I have not tested the code yet by running it.
KrisEnigma
left a comment
KrisEnigma
left a comment
There was a problem hiding this comment.
Added 2 commits as requested.
|
Linting need to be fixed and my last two comments need to be addressed. |
28094ca to
0ff34a8
Compare
|
I've addressed the requested changes. Please let me know if I mised something, I'm still new at contributing to open source software :) |
|
Hi @sithlord48 and @nbolton, I've addressed the feedback:
I've pushed the updates and requested reviews. Let me know if there's anything else! |
nbolton
left a comment
nbolton
left a comment
There was a problem hiding this comment.
I appreciate you probably wanted to avoid noise, but these things shouldn't happen normally so I'd consider them to be errors.
|
For future reference after you change stuff you can hit the little refresh icon by the reviewer and we will be notified to review again |
3 participants
This implements GitHub issue #8006 - a hotkey to cycle through
connected computers in the Deskflow network.
Closes #8006