refactor: LogTests use private log member - #8903
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sithlord48
force-pushed
the
logTestImprovments
branch
from
August 29, 2025 11:55
498e147 to
fafed82
Compare
sithlord48
force-pushed
the
logTestImprovments
branch
from
August 29, 2025 12:19
fafed82 to
d596221
Compare
sithlord48
marked this pull request as draft
August 29, 2025 12:19
sithlord48
force-pushed
the
logTestImprovments
branch
2 times, most recently
from
August 29, 2025 12:46
3cc2d9d to
101ffe2
Compare
sithlord48
marked this pull request as ready for review
August 29, 2025 12:51
sithlord48
force-pushed
the
logTestImprovments
branch
from
August 29, 2025 13:06
101ffe2 to
39cb3dc
Compare
nbolton
previously approved these changes
Aug 29, 2025
sithlord48
force-pushed
the
logTestImprovments
branch
from
August 29, 2025 13:52
39cb3dc to
c4a8cff
Compare
nbolton
approved these changes
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was to be part of #8902
m_logvar in place of making a new Log object for each test