Skip to content

refactor: New LogWidget to handle log output in the mainwindow - #8877

Merged
nbolton merged 2 commits into
masterfrom
updateLogToDock
Sep 1, 2025
Merged

refactor: New LogWidget to handle log output in the mainwindow#8877
nbolton merged 2 commits into
masterfrom
updateLogToDock

Conversation

@sithlord48

@sithlord48 sithlord48 commented Aug 22, 2025

Copy link
Copy Markdown
Member

fixes #8874

  • Make a LogWidget Manually add it into our gui.
  • Move the LogWidget to a dock on the bottom of the window. Simplifying resize alot.

Considering making the dock floatable also but will do in another PR.

@sithlord48
sithlord48 requested a review from nbolton August 30, 2025 15:05
@sithlord48
sithlord48 marked this pull request as ready for review August 30, 2025 15:06
@sithlord48
sithlord48 marked this pull request as draft August 31, 2025 14:40
@sithlord48
sithlord48 marked this pull request as ready for review August 31, 2025 15:14
@nbolton

This comment was marked as outdated.

@nbolton

nbolton commented Sep 1, 2025

Copy link
Copy Markdown
Member

Just curious, what's the handle about? Might be confusing for users.

Screencast.From.2025-09-01.10-27-16.mp4

@nbolton

nbolton commented Sep 1, 2025

Copy link
Copy Markdown
Member

I clicked the 'X' on macOS, and it crashed.

Oh shit, this is in master. Raised a new bug:

Edit: Fixed in:

@sithlord48

sithlord48 commented Sep 1, 2025

Copy link
Copy Markdown
Member Author

The handle is there if we allow resize of the dock area .. If we allow undocking or moving you can move it that way

Should we just make its own dialog? and not let it dock?

Edit: to remove that handle the dock needs to be a fixed vertical size so we have to do all the resize manually to avoid that . I would suspect GNOME is gonna hate that.. Another option is to allow the user to move the dock around , to do this we must let the user always resize the window, so we have more chances for it to not log great if you pull out the log etc. I've been playing with a 3rd option allowing the user to float then redock the log but this is not working great due to our resize code. I am all for making it a floating dock that looks like a dialog , i would make it its own dialog (not a dock) but we need the log reading happen in main window until #8879

I do not think the log is critical feature for most users. As we do communicate most errors via dialogs from the GUI.

@nbolton

nbolton commented Sep 1, 2025

Copy link
Copy Markdown
Member

GNOME's gonna GNOME...

image image

Both are caused by Alt+Tab after changing the log visibility.

Edit: It only happens the 1st time you Alt+Tab after toggling log visibility. After that, it doesn't happen again. Seems like some kind of race condition or state/sequence bug related to resize. I can confirm this only happens on GNOME, never happened on KDE.

@nbolton
nbolton enabled auto-merge (rebase) September 1, 2025 15:24
@nbolton
nbolton merged commit 43ce3c5 into master Sep 1, 2025
31 checks passed
@nbolton
nbolton deleted the updateLogToDock branch September 1, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Window resizes too big/small in GNOME after toggling Log

2 participants