Skip to content

various small fixes - #8876

Merged
nbolton merged 5 commits into
masterfrom
qPrintables
Aug 22, 2025
Merged

various small fixes#8876
nbolton merged 5 commits into
masterfrom
qPrintables

Conversation

@sithlord48

@sithlord48 sithlord48 commented Aug 21, 2025

Copy link
Copy Markdown
Member

A couple of unrelated changes i didn't feel like making separate PRS for

  • Where possible use qPrintable in place of QString::toStdString().c_str()
  • Include io/FileSystem.h in SecureSocket cpp instead of header.
  • Adjust CoreProcess::onProcessFinished , do no restart the core if it stopped because an instance has already started.
  • Adjust the message for when the core exits due to a duplicate
  • Add fallback icons for the connect / disconnect buttons.

@nbolton This changes the daemon a little please take a bit of extra time testing the windows daemon on this branch.

@sithlord48
sithlord48 requested a review from nbolton August 21, 2025 21:20
@sithlord48 sithlord48 added the ✨ enhancement A suggested change to improve functionality label Aug 21, 2025
@sithlord48 sithlord48 changed the title use qPrintable various small fixes Aug 22, 2025
@nbolton

nbolton commented Aug 22, 2025

Copy link
Copy Markdown
Member

various small fixes

Maybe a better PR title would be...

Use qPrintable(), add fallback icons, fix core process handling, and update includes

Edit: Or, focus on the most significant change:

Don't retry Core start if already running, use qPrintable(), add fallback icons

@nbolton
nbolton merged commit 3e96c4d into master Aug 22, 2025
31 checks passed
@nbolton
nbolton deleted the qPrintables branch August 22, 2025 08:54
@sithlord48

Copy link
Copy Markdown
Member Author

It started as just the qPrintable .. change.

@nbolton

nbolton commented Aug 22, 2025

Copy link
Copy Markdown
Member

It started as just the qPrintable .. change.

Yeah I got that 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement A suggested change to improve functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants